feat: add flag set metadata for bulk response and failures #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
changed the title
toddbaert
requested review from
lukas-reining,
beeme1mr,
jonathannorris,
nicklasl,
Kavindu-Dodan and
thomaspoignant
beeme1mr
reviewed
Jan 22, 2025
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/flag-set-metadata
branch
from
e7d31b6 to
d7f9ef4
Compare
beeme1mr
reviewed
Jan 22, 2025
beeme1mr
approved these changes
Jan 24, 2025
lukas-reining
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the existing metadata flag prop to the bulk evaluation and to failures.
These cases are particularly important for telemetry (see our recent addition of appendix D). Even in error cases, flag metadata (such as the version, flag set id, etc) can be very useful in debugging and metrics. These additions facilitate these use cases, and are non-breaking and backwards compatible.
The existing
metadatastruct has been moved to the components section for reuse.