Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add operationIds, remove invalid property, fix tag casing #35

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

czechboy0
Copy link
Contributor

Summary

  • Added missing operationIds (important for generated code)
  • Removed the name property from the required list of featureCacheInvalidationPolling, as no such property exists there (anymore?)
  • Fixed tag casing to match the tags list at the root of the document

Test Plan

Used a local linter, verified the doc now generates cleanly with Swift OpenAPI Generator

@czechboy0 czechboy0 requested a review from a team as a code owner February 7, 2025 09:32
@czechboy0 czechboy0 changed the title Fixups: Add operationIds, remove invalid property, fix tag casing fix: Add operationIds, remove invalid property, fix tag casing Feb 7, 2025
@beeme1mr
Copy link
Member

beeme1mr commented Feb 7, 2025

Thanks @czechboy0! Is there a JSON schema linter you recommend? Perhaps we can improve our PR checks.

@czechboy0
Copy link
Contributor Author

Yeah I generally use https://github.com/daveshanley/vacuum

@beeme1mr beeme1mr merged commit 46c8f8a into open-feature:main Feb 7, 2025
3 checks passed
@czechboy0 czechboy0 deleted the hd-fixups branch February 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants