Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use existing submodule version for e2e tests #444

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

beeme1mr
Copy link
Member

This PR

  • modifies the submodule set in the E2E tests to use the existing .gitmodule configuration.

Notes

The E2E tests will now use the submodule sha instead of pulling the latest. As a added benefit, Renovate should automagically open PRs when the spec repo is updated.

@beeme1mr beeme1mr requested review from chrfwow and gruebel February 11, 2025 23:55
Signed-off-by: Michael Beemer <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (2951eb2) to head (e2a95f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          32       32           
  Lines        1621     1621           
=======================================
  Hits         1584     1584           
  Misses         37       37           
Flag Coverage Δ
unittests 97.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@gruebel gruebel merged commit 5ae8571 into main Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants