Add gherkin tests to verify evaluation details in finally hooks #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
aepfli
reviewed
Jan 16, 2025
aepfli
reviewed
Jan 16, 2025
aepfli
reviewed
Jan 16, 2025
aepfli
reviewed
Jan 16, 2025
aepfli
reviewed
Jan 16, 2025
|
I extracted the hook tests into their own file |
Signed-off-by: christian.lutnik <[email protected]>
aepfli
reviewed
Jan 16, 2025
Signed-off-by: christian.lutnik <[email protected]>
beeme1mr
reviewed
Jan 16, 2025
Signed-off-by: christian.lutnik <[email protected]>
aepfli
approved these changes
Jan 20, 2025
Signed-off-by: christian.lutnik <[email protected]>
beeme1mr
reviewed
Jan 27, 2025
Signed-off-by: christian.lutnik <[email protected]>
aepfli
reviewed
Jan 28, 2025
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
toddbaert
approved these changes
Feb 6, 2025
beeme1mr
approved these changes
Feb 7, 2025
chrfwow
deleted the
Add-evaluation-details-to-finally-hook-stage-#403
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds gherkin tests to verify the evaluation details passed to the finally hooks
Related Issues
Part of open-feature/.github#65, open-feature/php-sdk#140, open-feature/python-sdk#403, open-feature/dotnet-sdk#328, open-feature/java-sdk#1246, and open-feature/js-sdk#1109
Follow-up Tasks
Implement the test steps in the repos