Skip to content

Commit

Permalink
🐛 [#5088] Ensure collapsed metadata fieldset is not hidden
Browse files Browse the repository at this point in the history
When a lot of variables are selected, the metadata fieldset gets pushed down in the modal. If it is collapsed, this causes it to disappear and not be accessible at all. The CSS styling for this collapsed class contains an `overflow: hidden` property that causes this.

This change adds a custom scss class openforms-fieldset, which overrides it to `overflow: visible`
  • Loading branch information
viktorvanwijk committed Feb 13, 2025
1 parent a1a1b00 commit 93e272c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const JSONDumpOptionsForm = ({name, label, schema, formData, onChange}) => {
defaultMessage="Metadata variables"
/>
}
extraClassName='openforms-fieldset'
collapsible
initialCollapsed
>
Expand Down
9 changes: 9 additions & 0 deletions src/openforms/scss/components/admin/_fieldset.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/**
* The django admin `.collapsed` styling on fieldset elements sets `overflow: hidden;`.
* Seeing how we already hide the fieldset content in the javascript code,
* the `overflow: hidden;` only hides the fieldset toggle (which we want to keep visible)
*/
.openforms-fieldset.collapsed {
overflow: visible !important;
}

1 change: 1 addition & 0 deletions src/openforms/scss/components/admin/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
@import './column-field-value';
@import './confirmation-email-template';
@import './variablemapping';
@import './fieldset';

// Form design UI
@import './select';
Expand Down

0 comments on commit 93e272c

Please sign in to comment.