Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing postcode does not trigger update of "DeriveStreetName" #2566

Open
LaurensBurger opened this issue Jan 17, 2023 · 6 comments
Open

Changing postcode does not trigger update of "DeriveStreetName" #2566

LaurensBurger opened this issue Jan 17, 2023 · 6 comments

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jan 17, 2023

Product versie / Product version

2.0.2

Omschrijf het probleem / Describe the bug

intern: LV 41

When a user changes the postcode - the fields derived from this field do not update. They will stay filled in by the old street name that was derived from the initial postcode.

Initial postcode, house number input and derived streetname:
image

After changing the postcode and house number:
image

Only after manually removing street name and city do this fields update to the newly entered postcode.
This can be seen in the network tab, where changing the postcode olny triggers a "check_logic" and removing the streetname triggers a "get_street_name_and_city"

Verwacht gedrag / Expected behavior

If a postcode is altered to something different the "get_street_name_and_city" call should be made to ensure the derived fields are properly updated.

Screen resolution

None

Device

None

OS

None

Browser

No response

@LaurensBurger LaurensBurger added bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 17, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Jan 17, 2023

This is deliberately, as when the user fills in the detail manually, they would be overwritten again when postcode/house number changes. See #1832 (and comment #1832 (comment) in particular)

@LaurensBurger
Copy link
Collaborator Author

Would this make sense:
if a street/city field is derived from a postcode > put in "read only" mode automatically. Allow user to manually edit the fields after clicking on something, which disables the lookup for the field.

@sergei-maertens
Copy link
Member

We'll have to check that with Joeri - as you can see in the other issue there has been much discussion about this and for now to autofill (always) you have to mark the derived fields as read-only.

@joeribekker
Copy link
Contributor

If I look at Coolblue, it works like this:

  1. Only show postalcode, number and addition editable fields
  2. Fill in values: Resolves to an address? Go to 3a. No address? Go to 3b.
    3a. Show read-only woonplaats and street
    3b Show editable woonplaats and street fields
  3. Change the postalcode, etc. values -> go to 2

Can we make this @LaurensBurger ?

@LaurensBurger
Copy link
Collaborator Author

@joeribekker Sounds good.
from a form designer perspective i would love if this was "packaged" as a single special component:

Postcode:
Number:
Streetname:
City:

Which is only available after setting up the BAG plugin.

@joeribekker
Copy link
Contributor

joeribekker commented Jul 15, 2024

Autofill scenario / Anonymous:

  1. Only show postalcode, number and addition as editable fields
  2. Fill in values: Resolves to an address? Go to 3a. No address? Go to 3b.
    3a. Show read-only woonplaats and street
    3b. Show editable woonplaats and street fields
  3. Change the postalcode, etc. values -> go to 2

BRK scenario:

Autofill is not relevant for this scenario
City and streetname are not needed

Prefill scenario:

*Autofill not relevant (maybe it is when prefill is down)
*Connect it to to BRP / KvK and requires DigiD or eHerkenning
All fields are read-only unless there is a problem retrieving the data

Laurens:

  • As a form builder, you want 1 component that does it all
  • Currently, it can only be for a anonymous form
  • It's useless because when logged in it should prefill

Also discussion on whether data is authentiek or not
And, what does the end-user expect how it works.
Utrecht showed prefill really different to indicate its authentic.

@sergei-maertens sergei-maertens added topic: address and removed bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants