Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2699] Uploads in repeating group #2704

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

SilviaAmAm
Copy link
Contributor

Fixes #2699

@SilviaAmAm SilviaAmAm added the needs-backport Fix must be backported to stable release branch label Feb 14, 2023
@SilviaAmAm SilviaAmAm marked this pull request as draft February 14, 2023 16:16
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 93.99% // Head: 94.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f00c1f8) compared to base (cf66825).
Patch coverage: 97.29% of modified lines in pull request are covered.

❗ Current head f00c1f8 differs from pull request most recent head b8b10bd. Consider uploading reports for the commit b8b10bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
+ Coverage   93.99%   94.00%   +0.01%     
==========================================
  Files         595      595              
  Lines       17997    18028      +31     
  Branches     2034     2045      +11     
==========================================
+ Hits        16916    16947      +31     
- Misses        786      787       +1     
+ Partials      295      294       -1     
Impacted Files Coverage Δ
src/openforms/submissions/attachments.py 89.07% <97.05%> (-3.39%) ⬇️
src/openforms/formio/utils.py 100.00% <100.00%> (ø)
...forms/registrations/contrib/camunda/serializers.py 100.00% <0.00%> (ø)
src/openforms/conf/base.py 93.02% <0.00%> (+0.03%) ⬆️
src/openforms/utils/api/drf_jsonschema.py 90.32% <0.00%> (+29.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SilviaAmAm SilviaAmAm force-pushed the fix/2699-uploads-in-repeating-group branch from e0a9996 to 5542c83 Compare February 15, 2023 09:02
@SilviaAmAm SilviaAmAm marked this pull request as ready for review February 15, 2023 09:21
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a ticket to refactor this upload handling into a more robust, easier testable setup. This suffices as a bandaid, but it won't hold up in the future.

@SilviaAmAm
Copy link
Contributor Author

New issue: #2713

@SilviaAmAm SilviaAmAm force-pushed the fix/2699-uploads-in-repeating-group branch from 17001a7 to f00c1f8 Compare February 15, 2023 14:42
@sergei-maertens sergei-maertens force-pushed the fix/2699-uploads-in-repeating-group branch from f00c1f8 to b8b10bd Compare February 15, 2023 15:30
@sergei-maertens sergei-maertens merged commit a14a944 into master Feb 15, 2023
@sergei-maertens sergei-maertens deleted the fix/2699-uploads-in-repeating-group branch February 15, 2023 16:41
@sergei-maertens
Copy link
Member

Backported in 667358a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploads in repeating group missing from attachments in submission
2 participants