-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2699] Uploads in repeating group #2704
Conversation
Codecov ReportBase: 93.99% // Head: 94.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 93.99% 94.00% +0.01%
==========================================
Files 595 595
Lines 17997 18028 +31
Branches 2034 2045 +11
==========================================
+ Hits 16916 16947 +31
- Misses 786 787 +1
+ Partials 295 294 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e0a9996
to
5542c83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create a ticket to refactor this upload handling into a more robust, easier testable setup. This suffices as a bandaid, but it won't hold up in the future.
New issue: #2713 |
17001a7
to
f00c1f8
Compare
f00c1f8
to
b8b10bd
Compare
Backported in 667358a |
Fixes #2699