[#5006] Ability to manually fill in addressNL streetname and city
#5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
force-pushed
the
feature/5006-addressnl-ability-to-manually-edit-streetname-city
branch
from
cde749b to
43db85b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5022 +/- ##
==========================================
- Coverage 96.71% 96.68% -0.03%
==========================================
Files 770 770
Lines 26489 26515 +26
Branches 3453 3461 +8
==========================================
+ Hits 25618 25637 +19
- Misses 607 611 +4
- Partials 264 267 +3 ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
feature/5006-addressnl-ability-to-manually-edit-streetname-city
branch
4 times, most recently
from
1c03258 to
c24cb2b
Compare
Comment on lines
491
to
582
| # when the user fills in manually the city and the street name we do not | ||
| # need to check the secret city - street name combination | ||
| if not auto_populated: | ||
| return attrs |
There was a problem hiding this comment.
ah okay, and because autoPopulated = False we then also know in the registration backend that the data can potentially not be trusted, right?
There was a problem hiding this comment.
Yes, this is how I thought about it.Let me know if you agree.
10 tasks
vaszig
force-pushed
the
feature/5006-addressnl-ability-to-manually-edit-streetname-city
branch
from
c24cb2b to
e645729
Compare
|
Missing the dutch translations for this.. |
vaszig
force-pushed
the
feature/5006-addressnl-ability-to-manually-edit-streetname-city
branch
from
e645729 to
bb3500e
Compare
…eetname and city Updated street name and city serializer fields in order to be able to require these fields in case the component is required.
vaszig
force-pushed
the
feature/5006-addressnl-ability-to-manually-edit-streetname-city
branch
from
bb3500e to
8d660e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5006
Needs
Changes
the component is required.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene