Add API endpoint for default fixed metadata variables of JSON dump plugin #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5094 +/- ##
=======================================
Coverage 96.74% 96.75%
=======================================
Files 771 774 +3
Lines 26636 26657 +21
Branches 3467 3468 +1
=======================================
+ Hits 25770 25791 +21
Misses 605 605
Partials 261 261 ☔ View full report in Codecov by Sentry. |
viktorvanwijk
force-pushed
the
bug/5087-fixed-metadata-variables-are-not-shown-in-options-of-json-dump-registration-backend
branch
3 times, most recently
from
bbc2a0c to
ac916d9
Compare
vaszig
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
I am not completely familiar with the feature but this looks ok to me.
Having read the possible approaches you mention in the issue itself, I agree with the one that you selected. I don't know though if there was another solution that doesn't come to my mind now.
Because the initial value of fixed metadata variables is set to an empty list and the fixed metadata variables field in the serializer was not set to read only, they would be overwritten when saving the form, resulting in a permanent empty list of fixed variables. This fix adds an API endpoint to fetch the default fixed variables dynamically in the frontend. This means they will be available directly when setting up the plugin for the first time.
…ables table of JSON dump plugin If the JSON dump plugin was not completely initialized yet (selected but not saved), and the user navigated to the registration variables of the variables table, the backend options would be an empty object, causing a crash.
viktorvanwijk
force-pushed
the
bug/5087-fixed-metadata-variables-are-not-shown-in-options-of-json-dump-registration-backend
branch
from
23d2918 to
c47324c
Compare
robinmolen
deleted the
bug/5087-fixed-metadata-variables-are-not-shown-in-options-of-json-dump-registration-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5087
Changes
Add API endpoint for default fixed metadata variables of JSON dump plugin.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene