-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5039] Fix email registration errors #5098
[#5039] Fix email registration errors #5098
Conversation
216c18b
to
3ebd8a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5098 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 774 775 +1
Lines 26657 26662 +5
Branches 3468 3468
=======================================
+ Hits 25787 25792 +5
Misses 608 608
Partials 262 262 ☔ View full report in Codecov by Sentry. |
3ebd8a0
to
791b5d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected :). As you already pointed out, though, might be nice if there is a solution which will work for all option forms, not only this plugin.
src/openforms/js/components/admin/form_design/registrations/email/EmailOptionsFormFields.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/registrations/email/EmailOptionsFormFields.js
Outdated
Show resolved
Hide resolved
791b5d8
to
31b74f0
Compare
Accepting this as it is - I think with the UX rework we'll have the chance to fix this properly so that you don't have to think about it at all anymore. |
Backports:
|
Closes #5039
Changes
nonField
errors for a combination of fields and these were not shown on the frontend. Fixed these by showing them on the top of the modal.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene