Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5039] Fix email registration errors #5098

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 11, 2025

Closes #5039

Changes

  • Email registration used nonField errors for a combination of fields and these were not shown on the frontend. Fixed these by showing them on the top of the modal.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Feb 11, 2025
@vaszig vaszig force-pushed the fix/5039-not-showing-errors-in-email-registration branch from 216c18b to 3ebd8a0 Compare February 11, 2025 07:28
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (a4e2c38) to head (31b74f0).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5098   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         774      775    +1     
  Lines       26657    26662    +5     
  Branches     3468     3468           
=======================================
+ Hits        25787    25792    +5     
  Misses        608      608           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as draft February 11, 2025 09:38
@vaszig vaszig force-pushed the fix/5039-not-showing-errors-in-email-registration branch from 3ebd8a0 to 791b5d8 Compare February 19, 2025 09:30
@vaszig vaszig marked this pull request as ready for review February 19, 2025 09:30
Copy link
Contributor

@viktorvanwijk viktorvanwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected :). As you already pointed out, though, might be nice if there is a solution which will work for all option forms, not only this plugin.

@vaszig vaszig force-pushed the fix/5039-not-showing-errors-in-email-registration branch from 791b5d8 to 31b74f0 Compare February 24, 2025 12:00
@sergei-maertens
Copy link
Member

Accepting this as it is - I think with the UX rework we'll have the chance to fix this properly so that you don't have to think about it at all anymore.

@sergei-maertens sergei-maertens merged commit 2c8d8a9 into master Feb 26, 2025
32 of 33 checks passed
@sergei-maertens sergei-maertens deleted the fix/5039-not-showing-errors-in-email-registration branch February 26, 2025 10:37
sergei-maertens pushed a commit that referenced this pull request Feb 26, 2025
@sergei-maertens
Copy link
Member

Backports:

  • 3.0.x: 4b1ecdf
  • 2.8.x: skipped as it didn't have the UX rework yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
3 participants