Components keeping original defaultValue when editing

[robinmolen]

Closes #5104

Changes

When creating radio component the configuration defined in the component schema will be used. Providing an empty string as the defaultValue. If you leave the defaultValue as an empty string, save this component and edit it again, the defaultValue will change to null. This defaultValue change happens because of how we construct the component data for the edit modal.

In the WebformBuilder.editComponent we receive the component property, which is a simplified representation of the component (a sub-set of all the component information). If the defaultValue is a falsey value, like in this case an empty string, then defaultValue won't be present in this component prop. When reconstructing the component to its full representation, the defaultValue defined in the Formio component schema will be used (null).

To make sure we retain the actual component defaultValue, we combine the original prop (which is the original component data) and the reconstructed component data.

For now i've opted to only added the defaultValue of the original data. Using the entire original object should be save, but to know for sure would require some more testing.

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (e7e8155) to head (f635fe0).
Report is 14 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5123   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         775      775           
  Lines       26662    26664    +2     
  Branches     3468     3469    +1     
=======================================
+ Hits        25792    25794    +2     
  Misses        608      608           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sergei-maertens]

I'm terrified of this change because of the earlier issues that happened with it, and on how Formio itself figures out the default value for a component: https://github.com/formio/formio.js/blob/bebc2ad73cad138a6de0a8247df47f0085a314cc/src/components/_classes/component/Component.js#L2302

Can you please make sure that all the old reported bugs are not re-introduced and test them manually? You should be able to figure out which ones that are from the commit history/git blame.

[sergei-maertens]

We should also document the manual JSON editing requirement when backporting the fix. For the master branch, we can do a data migration.