sync restore_command with restore_command_hint if missing #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NJrslv
force-pushed
the
njrslv/get_missing_restore_cmd
branch
from
e60ec9a to
bfe3961
Compare
NJrslv
commented
Oct 28, 2025
NJrslv
commented
Oct 28, 2025
|
Should add a test with timeline collision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Read
restore_command_hintfrompostgresql.confduring promotion whenrestore_commandis missing fromrecovery.conf.Why
pg_basebackup/pg_rewinddon't writerestore_commandduringrecovery.confgeneration, sorecovery.confshould always be missingrestore_command.For what
Solves timeline collisions. During promotion, a newer timeline might exist in the archive. If the promoting segment doesn't know about it, it could pick locally the same timeline ID as in the archive. Later when pushing to the archive, this causes errors that the timeline ID already exists.
Tests
Since the issue isn't solved in
pg_basebackuporpg_rewind, the choice of recovery method before promotion doesn't matter. I putrestore_command_hintinpostgresql.confforpg_rewindtests and verified execution.I didn't reproduce the timeline collision on my demo cluster. If you think I should, please leave a comment with the reproduction suggestions (tests where to put it).