Skip to content

Adds packaging and continuous integration (CI) support#91

Merged
guoguojenna merged 14 commits intoopen-iscsi:masterfrom
guoguojenna:527-ci
Sep 26, 2025
Merged

Adds packaging and continuous integration (CI) support#91
guoguojenna merged 14 commits intoopen-iscsi:masterfrom
guoguojenna:527-ci

Conversation

@guoguojenna
Copy link
Copy Markdown
Collaborator

@guoguojenna guoguojenna commented May 30, 2025

This pull request adds packaging and continuous integration (CI) support for the configshell-fb project, along with minor code maintenance. Here’s a summary of the key changes:

1. Packaging and CI configuration added:

  • Introduces .packit.yaml for Packit automation, enabling COPR builds, tests, and Fedora/EPEL sync.
  • Adds fedora/python-configshell-fb.spec for RPM packaging in Fedora.
  • Adds .fmf/version and ci-tests/sts.fmf for tmt test plan import.
  • Added a new GitHub Actions workflow for CodeQL analysis, which runs security and quality checks on Python code for pushes, pull requests, and on a weekly schedule.

2. Pre-commit enhancements:

  • Updates ruff-pre-commit from v0.7.1 to v0.11.11.
  • Adds packit/pre-commit-hooks for Packit config validation.
  • Updates pre-commit hook list—removes duplicates and improves formatting.
  • Adds pre-commit.ci configuration for automated fixes and monthly updates.

3. Python module cleanup:

  • Updates all in configshell/init.py to fix the order and content of exported symbols.

CI Workflow Summary for configshell-fb

  • pre-commit.ci
    Triggers:
    Pull Request creation/updates
    Manual trigger: /pre-commit.ci run

  • CodeQL Security Scanning
    Triggers:
    Push to master
    Pull Requests

  • Packit
    Triggers:
    Pull Requests (copr_build, tests)
    Releases (propose_downstream)
    Process:
    Builds an RPM package from the latest source code
    Installs the newly built configshell-fb RPM while keeping other dependencies from centos-stream or Fedora repositories
    Runs the test suite by Testing Farm

  • Testing Farm
    Triggered by Packit
    Runs integration tests
    Reports results

Status Checks Required
pre-commit.ci status, Code style and quality
CodeQL security checks, Security scanning
Packit COPR builds, RPM packaging and builds
Testing Farm results, Integration testing

Overall:
This PR prepares configshell-fb for Fedora/EPEL packaging and improves automation/testing workflows. No functional code logic changes are introduced.

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@guoguojenna guoguojenna changed the title Add CodeQL security scanning workflow Adds packaging and continuous integration (CI) support May 30, 2025
@guoguojenna
Copy link
Copy Markdown
Collaborator Author

Note:

The testing-farm test failed, because of #89.

@guoguojenna
Copy link
Copy Markdown
Collaborator Author

pre-commit.ci review

@guoguojenna
Copy link
Copy Markdown
Collaborator Author

pre-commit.ci run

@guoguojenna
Copy link
Copy Markdown
Collaborator Author

Waiving failures - https://artifacts.dev.testing-farm.io/78e63f69-7bc4-4567-9a99-b71fcff39b3a/

FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.CompareAndWrite]
FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.ReceiveCopyResults]
FAILED libiscsi-local.py::TestLibiscsiLocal::test_libiscsi_test_cu[ALL.iSCSIResiduals.Write1*]
======== 3 failed, 60 passed, 1 xfailed, 1 xpassed in 87.99s (0:01:27) =========

@guoguojenna guoguojenna merged commit 0ebae5a into open-iscsi:master Sep 26, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants