Skip to content

Add read_mbytes and write_mbytes from statistics#124

Open
paultag wants to merge 1 commit intoopen-iscsi:masterfrom
paultag:paultag/feature/read-write-statistics
Open

Add read_mbytes and write_mbytes from statistics#124
paultag wants to merge 1 commit intoopen-iscsi:masterfrom
paultag:paultag/feature/read-write-statistics

Conversation

@paultag
Copy link
Copy Markdown

@paultag paultag commented Mar 2, 2018

This is a bit awkward at the moment, and should perhaps be refactored
into more statistical helpers, but for now, being able to grab the
read/write count to the device is fairly handy.

This is a bit awkward at the moment, and should perhaps be refactored
into more statistical helpers, but for now, being able to grab the
read/write count to the device is fairly handy.
@paultag
Copy link
Copy Markdown
Author

paultag commented Mar 2, 2018

I put this into StorageObject - I'm not sure if this depends on a particular backstore. If so, I'll pull this into either a function or a mixin that we can throw into the supported backstores.

Just a flag if anyone knows

@mikechristie
Copy link
Copy Markdown
Contributor

Would it be possible to make it more generic similar to how we get attributes/params?

For example, check out node.py:list_attributes() for how to loop over the statistics dir and put all of them in an array. We could then also do something like node.py:get_attribute() to get individual stats if needed.

I think we could get this to work at the storage object and target levels similar to how the attribute code works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants