Add read_mbytes and write_mbytes from statistics#124
Open
paultag wants to merge 1 commit intoopen-iscsi:masterfrom
Open
Add read_mbytes and write_mbytes from statistics#124paultag wants to merge 1 commit intoopen-iscsi:masterfrom
paultag wants to merge 1 commit intoopen-iscsi:masterfrom
Conversation
This is a bit awkward at the moment, and should perhaps be refactored into more statistical helpers, but for now, being able to grab the read/write count to the device is fairly handy.
Author
|
I put this into StorageObject - I'm not sure if this depends on a particular backstore. If so, I'll pull this into either a function or a mixin that we can throw into the supported backstores. Just a flag if anyone knows |
Contributor
|
Would it be possible to make it more generic similar to how we get attributes/params? For example, check out node.py:list_attributes() for how to loop over the statistics dir and put all of them in an array. We could then also do something like node.py:get_attribute() to get individual stats if needed. I think we could get this to work at the storage object and target levels similar to how the attribute code works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit awkward at the moment, and should perhaps be refactored
into more statistical helpers, but for now, being able to grab the
read/write count to the device is fairly handy.