Skip to content

Add missing f-string in configfs mount cmd#228

Open
xy2 wants to merge 1 commit intoopen-iscsi:masterfrom
xy2:patch-1
Open

Add missing f-string in configfs mount cmd#228
xy2 wants to merge 1 commit intoopen-iscsi:masterfrom
xy2:patch-1

Conversation

@xy2
Copy link
Copy Markdown

@xy2 xy2 commented Mar 22, 2026

Usually, this code is never reached.

But under some circumstances (running in a container, or configfs was not mounted at boot), this fails with:

mount: {config_dir}: mount point does not exist

example:

Traceback (most recent call last):
  File "/var/lib/kolla/venv/bin/cinder-rtstool", line 6, in <module>
    sys.exit(main())
             ^^^^^^
  File "/var/lib/kolla/venv/lib64/python3.12/site-packages/cinder/cmd/rtstool.py", line 287, in main
    create(backing_device, name, userid, password, iser_enabled,
  File "/var/lib/kolla/venv/lib64/python3.12/site-packages/cinder/cmd/rtstool.py", line 44, in create
    rtsroot = rtslib_fb.root.RTSRoot()
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/lib/kolla/venv/lib64/python3.12/site-packages/rtslib/root.py", line 86, in __init__
    mount_configfs()
  File "/var/lib/kolla/venv/lib64/python3.12/site-packages/rtslib/utils.py", line 437, in mount_configfs
    raise RTSLibError("Cannot mount configfs")
rtslib.utils.RTSLibError: Cannot mount configfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant