bugfix: Setting OMPI_MPI_THREAD_LEVEL to a value different than requested crashes #13211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
commented
Apr 25, 2025
| char *env; | ||
|
|
||
| ompi_hook_base_mpi_init_thread_top(argc, argv, required, provided); | ||
|
|
||
| /* Detect an incorrect thread support level, but dont report until we have the minimum | ||
| * infrastructure setup. | ||
| */ | ||
| if( (MPI_THREAD_SINGLE == required) || (MPI_THREAD_SERIALIZED == required) || |
There was a problem hiding this comment.
This is inconsistent with the way this is tested in MPI_INIT, I picked this resolution with an explicit individual check per value, this should be more in-tune with ABI values when that becomes relevant.
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
3 times, most recently
from
7a81ed0 to
b71461f
Compare
`requested` in `MPI_Init_thread` would invoke the error handler, even though it is an useful override in some threaded library use cases. Signed-off-by: Aurelien Bouteiller <[email protected]>
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
from
b71461f to
b481893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting OMPI_MPI_THREAD_LEVEL to a value different than
requestedinMPI_Init_threadwould invoke the error handler, even though it is an useful override in some threaded library use cases.