Skip to content

fix: Refactor RunClient.test.ts and RunManager.test.ts #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

seneyu
Copy link
Contributor

@seneyu seneyu commented Feb 24, 2025

Linked issue/ticket

N/A

Description

  • Added test clean up for both RunClient.test.ts and RunManager.test.ts files
  • Added test data object to testUtils.ts, reducing redundancy of listing example data in test files
  • Minor refactor in mlflow-js.yaml so we can check the GitHub Actions result when making PR to dev

Reproduction steps

N/A

Checklist

  • I've followed the Contributing guidelines
  • I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • I've linted, tested, and commented my code
  • I've updated documentation (if appropriate)

Copy link
Contributor

@austinbfraser austinbfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you Stephany!

@austinbfraser austinbfraser merged commit f61b917 into dev Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants