Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add meter scope configurator #3268

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Feb 11, 2025

Contributes to #2641

Adds scope configurator for Meters.

Changes

  • Updates the Metrics SDK to add support for MeterConfigurator as per the spec changes.
  • Adds a MeterConfig class that can be used to configure a meter's behavior as per spec.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e75db69
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67ad8f2a41f881000882d910

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (3ca3c76) to head (e75db69).

Files with missing lines Patch % Lines
sdk/src/metrics/meter.cc 53.13% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   87.96%   87.91%   -0.04%     
==========================================
  Files         205      207       +2     
  Lines        6407     6457      +50     
==========================================
+ Hits         5635     5676      +41     
- Misses        772      781       +9     
Files with missing lines Coverage Δ
sdk/include/opentelemetry/sdk/metrics/meter.h 57.15% <ø> (ø)
...k/include/opentelemetry/sdk/metrics/meter_config.h 100.00% <100.00%> (ø)
sdk/src/metrics/meter_config.cc 100.00% <100.00%> (ø)
sdk/src/metrics/meter_context.cc 77.34% <100.00%> (+1.28%) ⬆️
sdk/src/metrics/meter_provider.cc 87.18% <100.00%> (ø)
sdk/src/metrics/meter_provider_factory.cc 82.36% <100.00%> (+7.36%) ⬆️
sdk/src/metrics/meter.cc 60.50% <53.13%> (-1.85%) ⬇️

... and 1 file with indirect coverage changes

@psx95 psx95 force-pushed the add-meter-scope-config branch from 68b0151 to d151ba8 Compare February 11, 2025 21:17
@psx95 psx95 force-pushed the add-meter-scope-config branch from d151ba8 to e2c22df Compare February 11, 2025 21:42
@psx95 psx95 force-pushed the add-meter-scope-config branch from 5f9bdd3 to a674d49 Compare February 12, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant