Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link directory to support curl 8.12 #3272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owent
Copy link
Member

@owent owent commented Feb 13, 2025

Add link directory to support curl 8.12

Fixes #3271

Changes

Certain versions of libcurl link dependency libraries from the package manager's installation directory but don't expose the link directories. This patch resolves this issue and also corrects the target name of libcurl in the official build script.

  • Link directory of libcurl to find dependencies of libcurl 8.12.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Add link directory to support curl 8.12
@owent owent requested a review from a team as a code owner February 13, 2025 11:08
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d26ceab
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67add2bb67eedf00088624c1

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (3ca3c76) to head (d26ceab).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3272   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build with curl 8.12
1 participant