Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base version to common modules #12956

Closed
wants to merge 2 commits into from

Conversation

trask
Copy link
Member

@trask trask commented Dec 23, 2024

While working on #932, I am thinking that it would be good to add base version to the "-common" modules as well (since we may end up with other "-common" modules in the future for other base versions).

This PR is just an example of a few. Will follow up with the rest if this sounds good.

Here's the full list:

$ find instrumentation -type d -name "*-common*"
instrumentation/cassandra/cassandra-4-common
instrumentation/cassandra/cassandra-4.0-common
instrumentation/couchbase/couchbase-2-common
instrumentation/couchbase/couchbase-2.0-common
instrumentation/couchbase/couchbase-common
instrumentation/elasticsearch/elasticsearch-rest-common
instrumentation/elasticsearch/elasticsearch-transport-common
instrumentation/graphql-java/graphql-java-common
instrumentation/hibernate/hibernate-common
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-common
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common
instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-common
instrumentation/jaxrs/jaxrs-common
instrumentation/jaxws/jaxws-2.0-common-testing
instrumentation/jaxws/jaxws-3.0-common-testing
instrumentation/jaxws/jaxws-common
instrumentation/jedis/jedis-common
instrumentation/jetty/jetty-common
instrumentation/jms/jms-common
instrumentation/jsf/jsf-jakarta-common
instrumentation/jsf/jsf-javax-common
instrumentation/kafka/kafka-clients/kafka-clients-common
instrumentation/ktor/ktor-2-common
instrumentation/ktor/ktor-common
instrumentation/lettuce/lettuce-common
instrumentation/log4j/log4j-context-data/log4j-context-data-common
instrumentation/mongo/mongo-common
instrumentation/netty/netty-4-common
instrumentation/netty/netty-common
instrumentation/opensearch/opensearch-rest-common
instrumentation/play/play-ws/play-ws-common
instrumentation/redisson/redisson-common
instrumentation/rxjava/rxjava-3-common
instrumentation/rxjava/rxjava-3.0-common
instrumentation/servlet/servlet-common
instrumentation/servlet/servlet-javax-common
instrumentation/spring/spring-cloud-gateway/spring-cloud-gateway-common
instrumentation/spring/spring-data/spring-data-common
instrumentation/spring/spring-webmvc/spring-webmvc-common
instrumentation/tomcat/tomcat-common
instrumentation/vertx/vertx-http-client/vertx-http-client-common
instrumentation/xxl-job/xxl-job-common

@trask trask force-pushed the rename-some-common-modules branch from 21cfd3d to d73bd7a Compare December 23, 2024 05:17
@trask trask force-pushed the rename-some-common-modules branch from d73bd7a to 2a00677 Compare December 23, 2024 05:20
@trask trask marked this pull request as ready for review December 23, 2024 23:12
@trask trask requested a review from a team as a code owner December 23, 2024 23:12
@trask trask marked this pull request as draft December 23, 2024 23:14
@trask
Copy link
Member Author

trask commented Dec 23, 2024

Closing, going to send a better overview for consideration.

@trask trask closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant