-
Notifications
You must be signed in to change notification settings - Fork 1k
JAXWS metadata #14864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
JAXWS metadata #14864
Conversation
docs/instrumentation-list.yaml
Outdated
library_link: https://github.com/jakartaee/jax-ws-api | ||
features: | ||
- CONTROLLER_SPANS | ||
- CONTEXT_PROPAGATION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it really do context propagation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am i misinterpreting this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am i misinterpreting this?
Context propagation usually means passing the context through header between applications or inter thread context propagation where context is somehow passed from one thread to another. Perhaps storing the context and passing it to a callback could also be considered context propagation. The linked code just creates a span and activates the context that contains that span. I don't think that qualifies as context propagation. I think we need to clarify what CONTEXT_PROPAGATION
means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this was a misunderstanding on my part. I've updated the documentation to better match the more narrow definition and removed that label from these instrumentations.
…ve experimental feature descriptor entirely
Part of #13468
Along with the metadata, I also moved the
instrumentation/jaxws/jaxws-2.0-axis2-1.6-testing
module intoinstrumentation/jaxws/jaxws-2.0-axis2-1.6/testing
because it didn't seem necessary for them to be separate modules (there's only 1 module using the-testing
module , and there were no tests in thejaxws-2.0-axis2-1.6
module.)