Skip to content

Conversation

jaydeluca
Copy link
Member

Part of #13468

Along with the metadata, I also moved the instrumentation/jaxws/jaxws-2.0-axis2-1.6-testing module intoinstrumentation/jaxws/jaxws-2.0-axis2-1.6/testing because it didn't seem necessary for them to be separate modules (there's only 1 module using the -testing module , and there were no tests in the jaxws-2.0-axis2-1.6 module.)

@jaydeluca jaydeluca requested a review from a team as a code owner October 2, 2025 09:41
library_link: https://github.com/jakartaee/jax-ws-api
features:
- CONTROLLER_SPANS
- CONTEXT_PROPAGATION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really do context propagation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i misinterpreting this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i misinterpreting this?

Context propagation usually means passing the context through header between applications or inter thread context propagation where context is somehow passed from one thread to another. Perhaps storing the context and passing it to a callback could also be considered context propagation. The linked code just creates a span and activates the context that contains that span. I don't think that qualifies as context propagation. I think we need to clarify what CONTEXT_PROPAGATION means.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this was a misunderstanding on my part. I've updated the documentation to better match the more narrow definition and removed that label from these instrumentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants