Add code attributes to vaadin instrumentation #14882
Open
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Oct 3, 2025
Comment on lines
+177
to
+178
| "com.vaadin.flow.server.communication.rpc.EventRpcHandler", | ||
| "handle")); |
There was a problem hiding this comment.
this isn't very useful
i'm 50-50 whether it's good for consistency to emit these, or if it's pointless and we should just say no
There was a problem hiding this comment.
My initial impression was that this would be pointless, but considering that the span name is EventRpcHandler.handle providing the full class name might make it more clear what this span is about. I think I'm currently leaning more towards lets add it.
laurit
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7345