chore: check compatibility between reactor-core and lettuce #15472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id24535b21c004991b9bd6eec3c3f167903bc6ab0
Change-Id: Ia0e45b15e17a3566a957b1feca5a5f9ee7e21916
Change-Id: I905c820c42c59733f7f54f98bd93bfc3b2b39d75
Change-Id: Icd45c926cf4377b33664f63774aa8517ab0fc372
laurit
reviewed
Nov 27, 2025
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| public class DisableNoEntranceSpanAndMetricsTest extends AbstractLettuceClientTest { |
Contributor
There was a problem hiding this comment.
usually we leave test classes as package private
this class name is weird, consider renaming it
laurit
reviewed
Nov 27, 2025
|
|
||
| testing { | ||
| suites { | ||
| val test_compatibility by registering(JvmTestSuite::class) { |
Contributor
There was a problem hiding this comment.
all other suites are named in camelCase
this suite isn't automatically run you'll have to add it with
check {
dependsOn(testing.suites)
}
currently this test fails
laurit
reviewed
Nov 27, 2025
Comment on lines
+31
to
+45
| Tracing.withTraceContextProvider( | ||
| new TraceContextProvider() { | ||
| @Override | ||
| public TraceContext getTraceContext() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<TraceContext> getTraceContextLater() { | ||
| return TraceContextProvider.super.getTraceContextLater(); | ||
| } | ||
| }); | ||
| Tracing.getContext(); | ||
| Tracing.clearContext(); | ||
| Tracing.disabled(); |
Contributor
There was a problem hiding this comment.
looking at #10997 I'd assume that you don't need to call anything besides Tracing.getContext()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #10997