Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configuration options for log4j2 appender library #9079

Conversation

swar8080
Copy link
Contributor

Completes the log4j task mentioned in #6947

Also clarifies that the setting for extracting attributes from ThreadContext takes a comma separated list of properties to extract

@swar8080 swar8080 requested a review from a team July 30, 2023 23:34
@github-actions github-actions bot requested a review from theletterf July 30, 2023 23:34
| `otel.instrumentation.log4j-appender.experimental.capture-map-message-attributes` | Boolean | `false` | Enable the capture of `MapMessage` attributes. |
| `otel.instrumentation.log4j-appender.experimental.capture-marker-attribute` | Boolean | `false` | Enable the capture of Log4j markers as attributes. |
| `otel.instrumentation.log4j-appender.experimental.capture-context-data-attributes` | String | | List of context data attributes to capture. Use the wildcard character `*` to capture all attributes. |
| System property | Type | Default | Description |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white-space changes are from running the markdown formatting commands manually from #8968 (since it isn't automated yet). Not sure why it's formatting differently but this new format seems ok

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swar8080 !

@mateuszrzeszutek mateuszrzeszutek merged commit 12b1d3c into open-telemetry:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants