Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup after bytebuddy 1.14.8 release #9595

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented Oct 2, 2023

There was a minor issue when trying to use bytebuddy to read the class file version with ClassFileVersion.ofClassFile when I implemented #9239.

This is now fixed in bytebuddy and we can use a simpler method call and avoid relying on binary class file format since it is part of release 1.14.8.

Related PR on bytebuddy: raphw/byte-buddy#1510

@SylvainJuge SylvainJuge marked this pull request as ready for review October 2, 2023 15:09
@SylvainJuge SylvainJuge requested a review from a team October 2, 2023 15:09
@trask trask merged commit 6e97851 into open-telemetry:main Oct 2, 2023
@SylvainJuge SylvainJuge deleted the post-bytebuddy-release branch October 3, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants