Skip to content

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger self-assigned this Aug 21, 2025
@@ -30,7 +30,7 @@ public String getName() {
}

@Override
public SpanExporter create(DeclarativeConfigProperties config) {
public SpanExporter create(DeclarativeConfigProperties config, ComponentProviderLoader componentProviderLoader) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the vision was that you would be able to use DeclarativeConfigProperties.getComponentLoader()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a different type of loader - it's specifically for declarative config components - so it should probably called that way

The underlying problem is that the exporters need to be able to create a declarative component

@zeitlinger zeitlinger force-pushed the declarative-config-authenticator branch from c16fafd to 67e16e1 Compare August 26, 2025 15:06
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.96%. Comparing base (9631f54) to head (8e15034).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...incubator/config/EmptyComponentProviderLoader.java 0.00% 4 Missing ⚠️
...veConfigPropertiesWithComponentProviderLoader.java 80.00% 3 Missing ⚠️
...orter/otlp/internal/OtlpDeclarativeConfigUtil.java 81.81% 1 Missing and 1 partial ⚠️
.../incubator/config/DeclarativeConfigProperties.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.60%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7605      +/-   ##
============================================
- Coverage     89.99%   89.96%   -0.04%     
- Complexity     7079     7092      +13     
============================================
  Files           803      805       +2     
  Lines         21419    21452      +33     
  Branches       2086     2089       +3     
============================================
+ Hits          19276    19299      +23     
- Misses         1479     1488       +9     
- Partials        664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants