Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local build differs from CI build #904

Open
Flarna opened this issue Feb 15, 2022 · 2 comments
Open

Local build differs from CI build #904

Flarna opened this issue Feb 15, 2022 · 2 comments

Comments

@Flarna
Copy link
Member

Flarna commented Feb 15, 2022

Bootstrapping differs between local builds using npm install in root folder and CI builds.

Local builds execute lerna bootstrap --no-ci

CI builds execute lerna bootstrap --no-ci --hoist --nohoist='zone.js' --nohoist='mocha' --nohoist='ts-mocha'

I can't tell which variant is better/more correct but I think there should be no difference.

Refs.: #900 (fixes an issue which happens in CI but not local)

@Flarna Flarna added the bug Something isn't working label Feb 15, 2022
@Flarna Flarna added internal and removed bug Something isn't working labels Feb 15, 2022
@blumamir
Copy link
Member

blumamir commented Feb 21, 2022

I added it to the CI.
At the time, it was not possible to hoist with npm7 due to peer dependencies issues, so I had to disable the new peer-deps mechanism here.
I think it's best to review if those issues still affect us, and fix them if they do, so it always works for npm 7 + hoisting in CI and in local builds

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants