-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install @types/form-data #900
Conversation
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 10 10
Lines 701 701
Branches 142 142
=======================================
Hits 668 668
Misses 33 33 |
@@ -48,6 +48,7 @@ | |||
"devDependencies": { | |||
"@commitlint/cli": "16.0.2", | |||
"@commitlint/config-conventional": "16.0.0", | |||
"@types/form-data": "^2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@types/form-data": "^2.5.0", | |
"@types/form-data": "2.5.0", |
Most likely caused because I don't have this problem local therefore I assume some ci caching is additionally needed. Update: CI uses different lerna command to bootstrap => #904 |
I'm aware of that, but the confusing part is the fact that node-fetch is a dep of lerna and codecov - I wonder why does that affect our compilations. |
there is also following in instrumentation tedious: [email protected] => @azure/[email protected] => @azure/[email protected] => @azure/[email protected] => [email protected] and @types/[email protected] and the lerna hosting seems to move around/dedup stuff a bit. |
Thanks, @Flarna for your help bouncing this! I removed |
welcome! I guess once it's done here we should do the same in opentelemetry-js and opentelemetry-js-api repos. |
Which problem is this PR solving?
I honestly do not know what exactly caused the issue in the first place, because the first commit that had the issue on the
main
didn't have any code changes and I'm not able to repro that locally, but simply following the instructionstsc
suggested seems to make the compiler chill.Short description of the changes
Installed
@types/form-data
in the root.Created #901 to remove it later.
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.