Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install @types/form-data #900

Closed
wants to merge 1 commit into from

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Feb 15, 2022

Which problem is this PR solving?

I honestly do not know what exactly caused the issue in the first place, because the first commit that had the issue on the main didn't have any code changes and I'm not able to repro that locally, but simply following the instructions tsc suggested seems to make the compiler chill.

Short description of the changes

Installed @types/form-data in the root.
Created #901 to remove it later.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #900 (8e0a5c2) into main (b9a1381) will not change coverage.
The diff coverage is n/a.

❗ Current head 8e0a5c2 differs from pull request most recent head bd1b623. Consider uploading reports for the commit bd1b623 to get more accurate results

@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          10       10           
  Lines         701      701           
  Branches      142      142           
=======================================
  Hits          668      668           
  Misses         33       33           

@@ -48,6 +48,7 @@
"devDependencies": {
"@commitlint/cli": "16.0.2",
"@commitlint/config-conventional": "16.0.0",
"@types/form-data": "^2.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@types/form-data": "^2.5.0",
"@types/form-data": "2.5.0",

@Flarna
Copy link
Member

Flarna commented Feb 15, 2022

Most likely caused because @types/node-fetch version 2.6.0 was published which depends on form-data ^2.3.3 whereas the previous version 2.5.12 depended on form-data ^3.0.0.

I don't have this problem local therefore I assume some ci caching is additionally needed.

Update: CI uses different lerna command to bootstrap => #904

@rauno56
Copy link
Member Author

rauno56 commented Feb 16, 2022

Most likely caused because @types/node-fetch version 2.6.0 was published which depends on form-data ^2.3.3 whereas the previous version 2.5.12 depended on form-data ^3.0.0.

I'm aware of that, but the confusing part is the fact that node-fetch is a dep of lerna and codecov - I wonder why does that affect our compilations.

@Flarna
Copy link
Member

Flarna commented Feb 16, 2022

there is also following in instrumentation tedious: [email protected] => @azure/[email protected] => @azure/[email protected] => @azure/[email protected] => [email protected] and @types/[email protected]

and the lerna hosting seems to move around/dedup stuff a bit.

@rauno56
Copy link
Member Author

rauno56 commented Feb 16, 2022

Thanks, @Flarna for your help bouncing this! I removed codecov instead of going with this hack for now. Removing it was due anyway because it has been deprecated for a while now.

@rauno56 rauno56 closed this Feb 16, 2022
@Flarna
Copy link
Member

Flarna commented Feb 16, 2022

welcome! I guess once it's done here we should do the same in opentelemetry-js and opentelemetry-js-api repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants