Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Jun 21, 2024

(More details to come.)

Refs: #1856
Refs: open-telemetry/opentelemetry-js#4818

@rossipedia
Copy link

👋 As I mentioned in the other PR, here's my adapted plugin. I made a couple tweaks around caching results, in particular trying to use require.resolve() first before falling back to build.resolve(), and also grabbing a set of "interested" prefixes so we can eliminate modules we know we aren't interested in from the resolution process.

There might be more optimizations that can be done here, but this has gotten us to the "good enough" point. Hope you find it useful!

https://gist.github.com/rossipedia/341501ed93ea5b1089da143ac49e6697

… need for wait for batch span send at the end of app.js
Comment on lines +10 to +13
server.get('/ping', async (req, reply) => {
const bar = await redis.get('bar');
reply.send(`pong (redis key "bar" is: ${bar})`);
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
, but is not rate-limited.
@trentm
Copy link
Contributor Author

trentm commented Jun 25, 2025

Closing this for now. This was a PoC (part of a couple PRs). I don't expect to get back to this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants