Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency minimatch to v10 #2346

Closed

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 19, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
minimatch ^9.0.3 -> ^10.0.0 age adoption passing confidence

Release Notes

isaacs/minimatch (minimatch)

v10.0.1

Compare Source

v10.0.0

Compare Source

v9.0.5

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team July 19, 2024 01:28
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (dfb2dff) to head (709be96).
Report is 190 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   90.97%   90.42%   -0.56%     
==========================================
  Files         146      148       +2     
  Lines        7492     7333     -159     
  Branches     1502     1524      +22     
==========================================
- Hits         6816     6631     -185     
- Misses        676      702      +26     

see 62 files with indirect coverage changes

@blumamir
Copy link
Member

from CHANGELOG:

change log

10.0

  • Require node 20 or 22 and higher

So this is not safe to update IMO

@blumamir
Copy link
Member

On the other hand, this is only used in udpate-otel-deps.js script which is run manually, so perhaps it's ok

@blumamir
Copy link
Member

If we accept this PR, we will get a WARN in npm ci with node <20:

npm ci
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '10.2.4' }
npm WARN EBADENGINE }

Since the new major version is only dropping support for old node versions, and not fixing any issues according to the changelog. and since this dependency is only used for our internal script for updating otel deps, I think we should not merge it until dropping support for old node versions.

Closing this PR.

@blumamir blumamir closed this Jul 23, 2024
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 10.x releases. But if you manually upgrade to 10.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/minimatch-10.x branch July 23, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants