fix(redis): correct span handling for multi commands #3140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR fixes an issue in the Redis instrumentation for
MULTI
(transaction) commands where spans were not correctly handled for mixed command sets.Previously, the
MULTI
span did not follow the semantic conventions and could not accurately represent it in the span dataAccording to this part of the semantic conventions:
Short description of the changes
Updated the
db.operation.name
on theMULTI
span:MULTI GET
when all operations areGET
.MULTI
when commands are mixed, in compliance with the semantic conventions.Added support for
execAsPipeline
, so that whenMULTI
is executed withexecAsPipeline
, it is treated as a pipeline in Redis instrumentation.Expanded tests to cover multiple command scenarios.
Related issue: #3082