-
Notifications
You must be signed in to change notification settings - Fork 611
feat(instrumentation-memcached): support net.* and db.* semconv migra… #3169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(instrumentation-memcached): support net.* and db.* semconv migra… #3169
Conversation
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small nit on the test, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, you got some errors that need fixing 😅
attributes[ATTR_DB_SYSTEM] = DB_SYSTEM_VALUE_MEMCACHED; | ||
} | ||
if (instrumentation._dbSemconvStability & SemconvStability.STABLE) { | ||
attributes[ATTR_DB_SYSTEM_NAME] = DB_SYSTEM_VALUE_MEMCACHED; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use DB_SYSTEM_NAME_VALUE_MEMCACHED
for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started to do that but realized DB_SYSTEM_NAME_VALUE_MEMCACHED
is still experimental 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would mean adding a src/semconv.ts wiht a local copy of that var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see what you mean. Meh, I think it still counts as the right thing to do for the "stable" semconv.
DB_SYSTEM_VALUE_MEMCACHED
is also "Stability: Development" and arguably is deprecated because it is an enum for db.system
which is deprecated: https://github.com/open-telemetry/semantic-conventions/blob/41df6e41371948bb924cec6fe4468f0a68431852/model/database/deprecated/registry-deprecated.yaml#L370-L523
@maryliag I made the changes if you can have another look when you get a chance 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This adds support for using
OTEL_SEMCONV_STABILITY_OPT_IN
for controlled migration to stablenet.*
anddb.*
semconv. Thenet.*
attributes are controlled by thehttp[/dup]
token inOTEL_SEMCONV_STABILITY_OPT_IN
(as discussed here) anddb.*
with thedatabase[/dup]
token.Refs: open-telemetry/opentelemetry-js#5663
Refs: #2953