Skip to content

Conversation

JamieDanielson
Copy link
Member

This adds support for using OTEL_SEMCONV_STABILITY_OPT_IN for controlled migration to stable net.* and db.* semconv. The net.* attributes are controlled by the http[/dup] token in OTEL_SEMCONV_STABILITY_OPT_IN (as discussed here) and db.* with the database[/dup] token.

Refs: open-telemetry/opentelemetry-js#5663
Refs: #2953

@JamieDanielson JamieDanielson requested a review from a team as a code owner October 9, 2025 22:22
@github-actions github-actions bot added pkg:instrumentation-memcached pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Oct 9, 2025
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small nit on the test, otherwise lgtm

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, you got some errors that need fixing 😅

attributes[ATTR_DB_SYSTEM] = DB_SYSTEM_VALUE_MEMCACHED;
}
if (instrumentation._dbSemconvStability & SemconvStability.STABLE) {
attributes[ATTR_DB_SYSTEM_NAME] = DB_SYSTEM_VALUE_MEMCACHED;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use DB_SYSTEM_NAME_VALUE_MEMCACHED for this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to do that but realized DB_SYSTEM_NAME_VALUE_MEMCACHED is still experimental 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would mean adding a src/semconv.ts wiht a local copy of that var.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see what you mean. Meh, I think it still counts as the right thing to do for the "stable" semconv.

DB_SYSTEM_VALUE_MEMCACHED is also "Stability: Development" and arguably is deprecated because it is an enum for db.system which is deprecated: https://github.com/open-telemetry/semantic-conventions/blob/41df6e41371948bb924cec6fe4468f0a68431852/model/database/deprecated/registry-deprecated.yaml#L370-L523

@trentm trentm added has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions and removed pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Oct 10, 2025
@github-actions github-actions bot added the pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. label Oct 14, 2025
@JamieDanielson
Copy link
Member Author

@maryliag I made the changes if you can have another look when you get a chance 🙏

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-memcached pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants