-
Notifications
You must be signed in to change notification settings - Fork 215
Remove non-generic instrumentations from defaults #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove non-generic instrumentations from defaults #1734
Conversation
5ca8656
to
e5c0a54
Compare
I'm honestly content with this list:
While not extremely useful, DNS and Net might be relevant for some people and are generic enough that they might be worth keeping as default. |
…umentation-defaults
@serkan-ozal @rapphil What are your thoughts on that one? Maybe something to bundle with Otel 2.0 for a |
Yeah, let's keep this PR for the major release. |
Are we are intending to "major release" the lambda layers? I'm fine if we decide to just stay at |
Not sure if we can do that on the AWS level (tag) but removing default values is usually a major change because there might be dashboards using that set of instrumentation that will stop working correctly. |
@tylerbenson @serkan-ozal have we reached consensus on what's the next step to get this one sorted? |
This PR reduces the amount of default instrumentations. These are the instrumentations that are initialized by default when a user does not set the
OTEL_NODE_ENABLED_INSTRUMENTATIONS
environment variable on their lambda function.The current defaults include a lot of instrumentations that are not generic. e.g. the
express
instrumentation is only useful to users who use theexpress.js
framework in their lambda, but is currently part of the defaults.To start I have reduced the list of defaults to contain:
Having
http
instrumentation seems like a sensible default, as it is used under the hood by many other packages.What concerns
dns
andnet
instrumentation, I can see a good case for removing those from the defaults as well.dns
: Do we need dns lookup etc spans by default?net
: Do we need tcp level spans by default?I'm personally leaning towards removing these from defaults as well. Any input here is appreciated!
fixes #1735