👷 Laravel instrumentation 1.1.x #269
Conversation
|
|
||
| return $root | ||
| ->canBeDisabled() | ||
| ->addDefaultsIfNotSet() |
There was a problem hiding this comment.
I'd like to add a hooks array here with configuration of each hook, unless there's a better alternative?
There was a problem hiding this comment.
I think you can do that, the laravel configuration schema can accept any shape you can define with symfony/config. For example, create an array for each component that is instrumented, which can individually be turned on/off, configure other values, ...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
============================================
+ Coverage 82.52% 83.56% +1.03%
+ Complexity 2414 2274 -140
============================================
Files 167 144 -23
Lines 9711 8864 -847
============================================
- Hits 8014 7407 -607
+ Misses 1697 1457 -240 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
… constants from sem-conv 1.26.
ChrisLightfootWild
force-pushed
the
spi/laravel
branch
from
5d3210d to
a3cf950
Compare
ChrisLightfootWild
force-pushed
the
spi/laravel
branch
from
1a1daa0 to
504796e
Compare
ChrisLightfootWild
changed the title
| "php": "^8.0", | ||
| "php": "^8.1", | ||
| "ext-json": "*", | ||
| "ext-opentelemetry": "*", |
There was a problem hiding this comment.
Changed based on similar issue raised for PDO instrumentation.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity, but it can be reopened. Thank you for your contributions. |
WIP: current test approach needs tweaking.
Using new functionality provided via open-telemetry/opentelemetry-php#1304.
This should probably form the basis of a v1.1 package, so depends on a 1.0 release of the current Laravel instrumentation.