use a local const for grpc time conversions #1505
Conversation
using a newly-added const in ClockInterface breaks things for some older PHP versions, so lets use a local const for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
============================================
- Coverage 70.84% 70.78% -0.06%
Complexity 2762 2762
============================================
Files 408 408
Lines 8342 8342
============================================
- Hits 5910 5905 -5
- Misses 2432 2437 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -25,6 +24,8 @@ final class GrpcTransportFactory implements TransportFactoryInterface | |||
| { | |||
| use LogsMessagesTrait; | |||
|
|
|||
| public const MILLIS_PER_SECOND = 1_000; | |||
There was a problem hiding this comment.
If this was protected, might we discourage wider usage? (hopefully in favour of ClockInterface::MILLIS_PER_SECOND where applicable)
There was a problem hiding this comment.
Yes, absolutely. Since the class is final, I think it can be private.
using a newly-added const in ClockInterface breaks things for some older PHP versions, so lets use a local const for now