-
Notifications
You must be signed in to change notification settings - Fork 739
Update the botocore
instrumentation to emit events via the logs API instead of the deprecated events API
#3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py
Outdated
Show resolved
Hide resolved
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Outdated
Show resolved
Hide resolved
Updated dependencies to require opentelemetry-api >= 1.35, I think this can be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and nice to see this moving along
ACtually before this goes in I think we need to update the SDK Logger to attach the resource to the LogRecord like the SDK EventLogger does: https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py#L654-L764 |
Trying to follow. Is this related to Logging SDK vs Events SDK |
Yes. Event SDK emit adds resource, logging SDK does not. Logging SDK should do it, and there should be no SDK Log record (that's sort of tangentially related, the SDK logger expects an SDK log record when it should expect an API log record which has no resource on it) |
Description
Move
botocore
from the deprecated events API to the logs API.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've updated the existing unit tests to all pass.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.