Implement OpenAI Agents span processing #3817
Open
+1,191
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rads-1996
reviewed
Oct 8, 2025
|
|
||
| def _operation_name(self, span_data: Any) -> str: | ||
| span_type = getattr(span_data, "type", None) | ||
| if span_type == "generation": |
There was a problem hiding this comment.
are these span_types always going to be in lowercase?
rads-1996
reviewed
Oct 8, 2025
|
|
||
| @property | ||
| def type(self) -> str: | ||
| return "function" |
There was a problem hiding this comment.
these strings like function, generation, etc. are being used in multiple places, can these be made constants instead of hardcoding the values.
lzchen
reviewed
Oct 8, 2025
|
|
||
| processor = _OpenAIAgentsSpanProcessor(tracer=tracer, system=system) | ||
|
|
||
| tracing = _load_tracing_module() |
There was a problem hiding this comment.
Any reason why we are loading the module during init of the instrumentor and not at the beginning of runtime/
lzchen
reviewed
Oct 8, 2025
| return value | ||
|
|
||
|
|
||
| def _get_registered_processors(provider) -> list: |
There was a problem hiding this comment.
Nit: Include type annotations for provider and provide docstring on what the fields look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the previous barebones PR to include genai spans and traces.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing
cleanly with integer timestamps.
exporter errors.
timestamps and attribute mapping.
Environment
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.