-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a note for pip3 installations #1825
Conversation
In case some users have python3-pip installed, the commands to install the opentelemetry-api & opentelemetry-sdk is `pip3` instead of `pip`
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think libraries should be educating people about package managers in general. User systems can be vastly different from a standard python installation and it'd be impractical to document for every scenario.
This change seems to be pretty harmless though so approving.
May be we can add a pitfalls or FAQ page to the documentation to mention all such edge cases when they come up.
We have |
@owais @lonewolf3739 |
Yes |
@marcosflobo |
I appreciate the intention of this PR, but I agree that package installation details are outside the scope of this particular documentation. I suggest we close this PR. |
Closing in favor of #1875 |
In case some users have python3-pip installed, the commands to install the opentelemetry-api & opentelemetry-sdk is
pip3
instead ofpip
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: