Skip to content

infra: add griffe to public-symbols check CI #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2025
Merged

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jun 12, 2025

Close #4619

@emdneto emdneto requested a review from a team as a code owner June 12, 2025 00:12
@emdneto emdneto added build & infra Issues related to build & infrastructure. Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jun 12, 2025
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because we can always roll back. I don't want to bikeshed on the bash script because I think we will eventually need to write a python script possibly using the lower level API to configure skipping certain rules and package patterns

@emdneto emdneto marked this pull request as draft June 12, 2025 15:01
@emdneto
Copy link
Member Author

emdneto commented Jun 24, 2025

@emdneto emdneto marked this pull request as ready for review June 24, 2025 00:01
@emdneto emdneto requested review from xrmx and aabmass June 24, 2025 00:01
@xrmx xrmx enabled auto-merge (squash) July 1, 2025 12:41
@xrmx xrmx disabled auto-merge July 1, 2025 12:42
@emdneto
Copy link
Member Author

emdneto commented Jul 1, 2025

@open-telemetry/python-maintainers In release PRs probably the check will fail because we bump the version in version.py files and griffe can detect this as "breaking", like attribute changed. I'll confirm if we are running this check in release PRs. However, if that's the case, we can add the label to skip the public API symbols check.

@xrmx xrmx merged commit 62eed3d into open-telemetry:main Jul 11, 2025
471 of 472 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure. Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Griffe in CI to detect breaking changes
4 participants