-
Couldn't load subscription status.
- Fork 757
[logs-api/sdk] Rename several classes from Log to LogRecord #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[logs-api/sdk] Rename several classes from Log to LogRecord #4647
Conversation
|
Wondering as an alternative we can keep the old name around wrapped with deprecated to at least have a chance for downstream user to handle this more gently? e.g.: |
|
Thanks for reviewing @xrmx, addressed your feedback, let me know if there is any other concern |
|
I'm happy to resolve conflicts and update when release plan is defined |
Description
Rename the following classes to maintain consistency with specs and other languages implementations.
LogData to LogRecordData
LogLimits to LogRecordLimits
LogExporter to LogRecordExporter
LogExportResult to LogRecordExportResult
ConsoleLogExporter to ConsoleLogRecordExporter
InMemoryLogExporter to InMemoryLogRecordExporter
LogDeprecatedInitWarning to LogRecordDeprecatedInitWarning
LogDroppedAttributesWarning to LogRecordDroppedAttributesWarning
Fixes #4321
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?