-
Notifications
You must be signed in to change notification settings - Fork 716
[logs-api/sdk] Rename several classes from Log to LogRecord #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hectorhdzg
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
hectorhdzg:hectorhdzg/logrecrename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[logs-api/sdk] Rename several classes from Log to LogRecord #4647
hectorhdzg
wants to merge
9
commits into
open-telemetry:main
from
hectorhdzg:hectorhdzg/logrecrename
+264
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Wondering as an alternative we can keep the old name around wrapped with deprecated to at least have a chance for downstream user to handle this more gently? e.g.:
|
Thanks for reviewing @xrmx, addressed your feedback, let me know if there is any other concern |
xrmx
approved these changes
Jul 2, 2025
emdneto
approved these changes
Jul 3, 2025
tammy-baylis-swi
approved these changes
Jul 3, 2025
aabmass
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename the following classes to maintain consistency with specs and other languages implementations.
LogData to LogRecordData
LogLimits to LogRecordLimits
LogExporter to LogRecordExporter
LogExportResult to LogRecordExportResult
ConsoleLogExporter to ConsoleLogRecordExporter
InMemoryLogExporter to InMemoryLogRecordExporter
LogDeprecatedInitWarning to LogRecordDeprecatedInitWarning
LogDroppedAttributesWarning to LogRecordDroppedAttributesWarning
Fixes #4321
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?