Skip to content

Mark events API/SDK as deprecated #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DylanRussell
Copy link
Contributor

@DylanRussell DylanRussell commented Jun 24, 2025

Description

Mark the Events API/SDK as deprecated. The Logs API/SDK should be used instead. An event is now a LogRecord with the event_name field set.

See open-telemetry/opentelemetry-specification#4319 and open-telemetry/opentelemetry-specification#4260 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Just marking stuff as deprecated.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@DylanRussell DylanRussell requested a review from a team as a code owner June 24, 2025 13:23
@tammy-baylis-swi
Copy link
Contributor

The changes here lgtm if we agree that this will be part of next release.

Thanks for linking those spec issues. Could we also have a dedicated Python issue to include on the Python Logging RC board?

@DylanRussell
Copy link
Contributor Author

Sure created #4655 and added it to the board

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add deprecation to the module level public functions like

def get_event_logger_provider() -> EventLoggerProvider:

Co-authored-by: Riccardo Magliocchetti <[email protected]>
@DylanRussell
Copy link
Contributor Author

Ack I added the deprecation warnings to the module level public functions

@aabmass
Copy link
Member

aabmass commented Jun 26, 2025

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Should we go ahead and fix the contrib packages now? I don't remember if the independent versioned GenAI packages test against opentelemetry-api @ HEAD or not

@emdneto
Copy link
Member

emdneto commented Jun 27, 2025

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Should we go ahead and fix the contrib packages now? I don't remember if the independent versioned GenAI packages test against opentelemetry-api @ HEAD or not

Individual GenAI packages are being tested against the main and also against the lowest supported version of the API. I don't think it will be a problem in terms of testing because we are just deprecating things. Typechecker won't like this change though

@DylanRussell
Copy link
Contributor Author

I will go ahead and update the Contrib repo implementations now.. Up to y'all if you want to block this PR until that is done. IMO we should just merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants