Skip to content

refactor: change error level logging to debug level for resource dete… #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: change error level logging to debug level for resource dete… #1540

wants to merge 2 commits into from
+6 −6

Conversation

@yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented May 16, 2025

What does this pull request do?

Updates existings AWS resource detectors to use debug level logging for resource detection failure per the OTel spec.

Issues

#1538

kaylareopelle
kaylareopelle reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yiyuan-he! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Jun 22, 2025
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Jun 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Jul 25, 2025
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Sep 7, 2025
@kaylareopelle kaylareopelle removed the stale Marks an issue/PR stale label Oct 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylareopelle kaylareopelle kaylareopelle left review comments

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

stale Marks an issue/PR stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yiyuan-he @kaylareopelle