Skip to content

Conversation

@robertlaurin
Copy link
Contributor

Just a small patch to fix context not propagating across fibers when anthropics client enumerates calls.

model: :'beep boop'
)
stream.each do |event|
puts event.delta.content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this puts in the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, will remove

@robertlaurin robertlaurin force-pushed the anthropic-instrumentation-patch branch from 70771e4 to 82b44ac Compare September 11, 2025 18:44
@robertlaurin robertlaurin merged commit 9d90317 into open-telemetry:main Sep 11, 2025
62 checks passed
@arielvalentin
Copy link
Contributor

arielvalentin commented Sep 27, 2025

Did the instrumentation generator fail to add this to the test matrix? #1699

I added it and the tests are failing https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/18062521999/job/51400805943?pr=1699

  	from /opt/hostedtoolcache/Ruby/3.1.7/x64/lib/ruby/gems/3.1.0/gems/opentelemetry-sdk-1.9.0/lib/opentelemetry/sdk.rb:63:in `configure'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/anthropic/test/test_helper.rb:20:in `<top (required)>'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/anthropic/test/opentelemetry/instrumentation/anthropic/instrumentation_test.rb:7:in `require'
  	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/anthropic/test/opentelemetry/instrumentation/anthropic/instrumentation_test.rb:7:in `<top (required)>'
  	from /opt/hostedtoolcache/Ruby/3.1.7/x64/lib/ruby/gems/3.1.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb:21:in `require'
  	from /opt/hostedtoolcache/Ruby/3.1.7/x64/lib/ruby/gems/3.1.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb:21:in `block in <main>'
  	from /opt/hostedtoolcache/Ruby/3.1.7/x64/lib/ruby/gems/3.1.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb:6:in `select'
  	from /opt/hostedtoolcache/Ruby/3.1.7/x64/lib/ruby/gems/3.1.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb:6:in `<main>'
  /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/anthropic/lib/opentelemetry/instrumentation/anthropic/instrumentation.rb:24:in `patch': uninitialized constant Anthropic::Internal (NameError)
  
            ::Anthropic::Internal::Transport::PooledNetRequester.prepend(Patches::PooledNetRequester)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants