Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTelSdkResult for metric flush #2606

Merged

Conversation

cijothomas
Copy link
Member

Continuing from #2604

@cijothomas cijothomas requested a review from a team as a code owner February 4, 2025 21:40
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (4783b64) to head (38c69ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../src/metrics/periodic_reader_with_async_runtime.rs 0.0% 9 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 57.1% 3 Missing ⚠️
opentelemetry-otlp/src/metric.rs 0.0% 1 Missing ⚠️
...pentelemetry-sdk/src/metrics/in_memory_exporter.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 66.6% 1 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2606     +/-   ##
=======================================
- Coverage   79.2%   79.2%   -0.1%     
=======================================
  Files        118     118             
  Lines      22513   22511      -2     
=======================================
- Hits       17831   17829      -2     
  Misses      4682    4682             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 4a76c96 into open-telemetry:main Feb 4, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-flush-result branch February 4, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants