Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move traceid spanid traceflags to common #2609

Merged

Conversation

cijothomas
Copy link
Member

Trying to move TraceId,SpanId,TraceFlags outside of trace to common module.

@cijothomas cijothomas requested a review from a team as a code owner February 5, 2025 01:15
@cijothomas
Copy link
Member Author

@TommyCpp @lalitb Please review. I reexported from trace module too, so this should not be a breaking change...

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (dfeeac7) to head (24320e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2609   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        118     119    +1     
  Lines      22550   22550           
=====================================
  Hits       17830   17830           
  Misses      4720    4720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. thanks.

@cijothomas cijothomas merged commit 15b5fa4 into open-telemetry:main Feb 5, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/traceid-common branch February 5, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants