Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LogRecord to SdkLogRecord #2617

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas requested a review from a team as a code owner February 5, 2025 19:13
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (5f7f2d5) to head (0ee9298).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-proto/src/transform/logs.rs 50.0% 2 Missing ⚠️
opentelemetry-sdk/src/logs/log_processor.rs 88.2% 2 Missing ⚠️
...y-sdk/src/logs/log_processor_with_async_runtime.rs 85.7% 1 Missing ⚠️
opentelemetry-sdk/src/logs/logger_provider.rs 75.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2617   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        119     119           
  Lines      22531   22531           
=====================================
  Hits       17819   17819           
  Misses      4712    4712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 1fbaaf2 into open-telemetry:main Feb 5, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/logrecordrename2 branch February 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants