Skip to content

revert: reintroduce external producers #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spoutn1k
Copy link

@spoutn1k spoutn1k commented Jun 16, 2025

Fixes #2505

Changes

We re-introduce a way to get data from external sources after its removal in #2105.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Jun 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: spoutn1k / name: Jean-Baptiste Skutnik (3e40ec8)

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 31.57895% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.0%. Comparing base (eac368a) to head (3e40ec8).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 19 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 63.1% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3025     +/-   ##
=======================================
- Coverage   80.0%   80.0%   -0.1%     
=======================================
  Files        126     126             
  Lines      21879   21911     +32     
=======================================
+ Hits       17519   17529     +10     
- Misses      4360    4382     +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spoutn1k spoutn1k force-pushed the add-ext-producer branch from c7cfda9 to a4eca2d Compare July 4, 2025 07:14
@spoutn1k spoutn1k force-pushed the add-ext-producer branch from a4eca2d to 3e40ec8 Compare July 4, 2025 07:55
@spoutn1k spoutn1k changed the title Revert removal of external producers revert: reintroduce external producers Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement MetricProducer
1 participant