-
Notifications
You must be signed in to change notification settings - Fork 547
feat: Stabilize logger.enabled by removing spec_unstable_logs_enabled feature flag #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
=======================================
- Coverage 81.1% 80.0% -1.1%
=======================================
Files 126 126
Lines 24954 21879 -3075
=======================================
- Hits 20251 17519 -2732
+ Misses 4703 4360 -343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1d132dd
to
1316105
Compare
@@ -2,6 +2,8 @@ | |||
|
|||
## vNext | |||
|
|||
- **Breaking** Remove `spec_unstable_logs_enabled` feature flag - logger.enabled functionality is now always available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot The changelog make it sound like this is a breaking change to crate that is announced as stable. Given the feature flag was already marked "unstable", please modify changelog so that it'll not scare regular consumers of the crate with breaking change warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the changelog to remove the "Breaking" label and clarify this was removing an experimental feature flag. The entry now reads "Remove experimental spec_unstable_logs_enabled
feature flag - logger.enabled functionality is now stabilized and always available." (commit 8b8c805)
Co-authored-by: cijothomas <[email protected]>
This PR stabilizes the logger.enabled functionality by completely removing the
spec_unstable_logs_enabled
feature flag from all OpenTelemetry Rust crates as requested in the issue.Changes Made
Core Crates Updated
Key Functional Changes
Logger::event_enabled()
method is now always available (previously behind feature flag)LogProcessor::event_enabled()
trait method is now always availableLogExporter::event_enabled()
trait method is now always availableDocumentation & Cleanup
Breaking Change Notice
This is a breaking change for users who were explicitly enabling the
spec_unstable_logs_enabled
feature flag. However, the functionality remains identical - it's just always enabled now.Before:
After:
The logger.enabled functionality that was previously experimental is now stable and ready for production use.
Verification
Fixes #3020.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.