Skip to content

build: replicate tonic tls features #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: replicate tonic tls features #3180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7ecb6
build: replicate tonic tls features
jdrouet Sep 25, 2025
af00d1d
fix: add back empty tls feature
jdrouet Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion opentelemetry-otlp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ zstd-tonic = ["tonic/zstd"]
# http compression
gzip-http = ["flate2"]
zstd-http = ["zstd"]
tls = ["tonic/tls-ring"]
tls = []
Copy link
Member

@scottgerring scottgerring Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tonic feature flags impl referenced:

_tls-any = ["dep:tokio", "tokio?/rt", "tokio?/macros", "tls-connect-info"] # Internal. Please choose one of `tls-ring` or `tls-aws-lc`
tls-ring = ["_tls-any", "tokio-rustls/ring"]
tls-aws-lc = ["_tls-any", "tokio-rustls/aws-lc-rs"]

I believe the intention is that "_tls-any" is an "internal" feature, not something the user is intended to rely on, and is what's then used to guard the backend-independent TLS code.

With this in mind, and with an eye to maintaining backward compatibility, how about:

_tls-any = []  # Internal feature for TLS guards
tls-ring = ["_tls-any", "tonic/tls-ring"]    # User opts into ring
tls-aws-lc = ["_tls-any", "tonic/tls-aws-lc"] # User opts into aws-lc
tls = ["tls-ring"]  # Default to existing behaviour

This would need code changes too to move from tls to _tls-any in the feature guards - e.g. a bunch of stuff in exporter/tonic/mod:

opentelemetry-rust/opentelemetry-otlp/src/exporter/tonic/mod.rs

Lines 11 to 12 in 51eac97

#[cfg(feature = "tls")]
use tonic::transport::ClientTlsConfig;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this suggestion stretches the scope a little here, it would be great if one of the others piped in - @lalitb @bantonsson , does this seem reasonable to you?

tls-aws-lc = ["tls", "tonic/tls-aws-lc"]
tls-ring = ["tls", "tonic/tls-ring"]
tls-roots = ["tls", "tonic/tls-native-roots"]
tls-webpki-roots = ["tls", "tonic/tls-webpki-roots"]

Expand Down
Loading