Skip to content

Conversation

@svencowart
Copy link
Contributor

Small fix to allow cargo test --all to execute without immediately erroring.

Changes

  • Add #[cfg(feature = "experimental-http-retry")] gate to http_tests module
  • Replace wildcard imports with explicit imports in test modules
  • Remove unused imports from parent tests module
  • Move Duration import into http_tests submodule scope

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)

- Add #[cfg(feature = "experimental-http-retry")] gate to http_tests module
- Replace wildcard imports with explicit imports in test modules
- Remove unused imports from parent tests module
- Move Duration import into http_tests submodule scope
@svencowart svencowart requested a review from a team as a code owner October 24, 2025 23:12
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.8%. Comparing base (d721037) to head (ed0c838).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3212   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        128     128           
  Lines      23090   23090           
=====================================
  Hits       18676   18676           
  Misses      4414    4414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring scottgerring changed the title fix retry_classification tests fix: retry_classification tests Oct 27, 2025
Copy link
Member

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @svencowart , thanks for this!

It looks like we explicitly test with --all-features in the script we run in CI, but I don't see any reason we should break cargo test --all.

cargo test --workspace --all-features --lib

@svencowart
Copy link
Contributor Author

Hey @svencowart , thanks for this!

It looks like we explicitly test with --all-features in the script we run in CI, but I don't see any reason we should break cargo test --all.

cargo test --workspace --all-features --lib

This make sense. Especially because the contribution specifically calls out to use cargo test --all.

@TommyCpp TommyCpp merged commit 9bbe272 into open-telemetry:main Oct 28, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants